Use `int` instead of `float` to calculate `weights_ptr` #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

qianzhangxa wants to merge 1 commit into karpathy:master from qianzhangxa:patch-1

qianzhangxa commented Apr 27, 2024

The Config structure consists of 7 fields of int type, so we should use int instead of float when calculating weights_ptr.


          Use int instead of float to calculate weights_ptr

f5a9888

Contributor

jameswdelancey commented Apr 27, 2024

Haha yea. I noticed that too but the size is the same.

Contributor

jameswdelancey commented Apr 27, 2024

Been in the code a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet