simplify back propagation (remove unnecessary sequence traversal) #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original recursive back propagation algorithm performs breadth-first visiting of Values in the graph, simply to add them to a linear sequence. The sequence is then reversed and iterated over to invoke the _backward() function in each Value.
It is possible to invoke the _backward() function in a single pass during the breadth-first visiting of Values, without creating an interim linear sequence. This PR simplifies the algorithm accordingly.