Fix several sizing bugs #590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use updated kas-text, allowing use of
measure_heightwith a line limit. Fixes:SelectableTextandEditFieldcan more accurately set their minimum sizes based on text, justdpem.Opinionated fix: let
Stackinfer its minimum size only from the active page. Other size rules (ideal, margin, stretch) all infer from the max of used pages. This has two implications:Stackwill still try to be large enough for all pages (up to the size limit), but may now be smaller than the largest minimum.Stackforcibly sized below its minimum allows the active page to be shrunk correctly. Without this change, the active page could be larger than the widget even if it could actually be sized smaller.Fix: update window size requirements after resizing. This allows height-from-width requirements to be updated which may force a window to be taller when made narrower. (This was changed in #588 and is what allowed the gallery's
Stackto be sized too small.)