Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates all directional keys to use WASD as defaults #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nickfloyd
Copy link

@nickfloyd nickfloyd commented Aug 10, 2021

Fixes: #33

We want to default the up, left, down, and right movement keys to the more common WASD until a more extensible configuration solution can be built.

Acceptance Criteria:

  • When pressing W the character moves up
  • When pressing A the character moves left
  • When pressing S the character moves down
  • When pressing D the character moves right
  • When pressing up arrow the character moves up
  • When pressing left arrow the character moves left
  • When pressing down arrow the character moves down
  • When pressing right arrow the character moves right

VALIDATION

  1. Checkout this branch: change-directional-keys
  2. cargo run -- --asset-dir [LOCATION of your assets with an in gamer character that uses movement]
  3. Verify that W, A, S, D moves the character as expected

NOTES

  • We had some discussion around some configuration approaches that would work well but those will be a future concern.
  • Additionally I was thinking that we'd make this change to encapsulate up arrow || W but that just seemed to introduce unnecessary complexity that was going to be replaced by a future config feature.
  • This may need to be reconsidered for modified keyboard layouts and non-US layouts - though that can easily be an AC of the configuration work.

@nickfloyd nickfloyd requested a review from zicklag August 10, 2021 14:02
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2021

CLA assistant check
All committers have signed the CLA.

@zicklag
Copy link
Member

zicklag commented Aug 10, 2021

Thanks!

I think it would actually be good to support both the arrow keys and WASD until we get a config solution in place. That way we have a way that will work regardless of keyboard layout, and we don't confuse anybody who might have played the game before and now thinks its broken because the movement doesn't work anymore.

@nickfloyd
Copy link
Author

Thanks!

I think it would actually be good to support both the arrow keys and WASD until we get a config solution in place. That way we have a way that will work regardless of keyboard layout, and we don't confuse anybody who might have played the game before and now thinks its broken because the movement doesn't work anymore.

That makes good sense... I'll make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default directional keys to WASD
3 participants