bug(android): update notification instead of recreating #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need, because no ticker option available This reverts commit 694aa6a.
Owner
|
@DavidWiesner Sounds reasonable. I will take a look. |
|
cordova.plugins.backgroundMode.configure is not documented in the readme... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android the notification will always recreated when updating e.g. the text with
cordova.plugins.backgroundMode.configure({ text: "Upload 2 of 20 images" });.This will result in a flickering notification because the old notification will be replaced with a new one. If you only want to update elements in the notification you have to keep the old
Notification.Builder.