Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEOD-1531. Fix dataframe sort with a pivot with the new pandas v2 API #371

Merged
merged 1 commit into from
Dec 18, 2023
Merged

SEOD-1531. Fix dataframe sort with a pivot with the new pandas v2 API #371

merged 1 commit into from
Dec 18, 2023

Conversation

AzisK
Copy link
Contributor

@AzisK AzisK commented Dec 18, 2023

Optimize it by getting rid of reset_index and set_index method calls when sorting

@AzisK
SEOD-1531. Fix dataframe sort with a pivot with the new pandas v2 API
58b27aa 
Optimize it by getting rid of `reset_index` and `set_index` method calls when sorting
@AzisK AzisK self-assigned this Dec 18, 2023
@AzisK AzisK requested a review from a team as a code owner December 18, 2023 16:17
@AzisK AzisK merged commit 911938a into master Dec 18, 2023
3 of 4 checks passed
@AzisK AzisK deleted the fix-dataframe-sort-with-a-pivot-with-pandasv2 branch December 18, 2023 16:17
@coveralls
Copy link

Coverage Status

coverage: 93.426%. remained the same
when pulling 58b27aa on fix-dataframe-sort-with-a-pivot-with-pandasv2
into 574ebd2 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AzisK AzisK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AzisK @coveralls