-
Notifications
You must be signed in to change notification settings - Fork 4
response MUST NOT be affected by the Priority request header #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
draft-kazuho-httpbis-priority.md
Outdated
| properties of an HTTP request it receives, the server is expected to control the | ||
| cacheability or the applicability of the cached response, by using header fields | ||
| that control the caching behavior (e.g., Cache-Control, Vary). | ||
| A server MUST NOT generate different response based on the value of the Priority |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can generate a different Priority header in response, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 9fffd45, I've clarified that we are talking about "HTTP response" but not a response header field. Does that look better?
LPardue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I'm afraid we're losing a bit of guidance on the caching footguns with this? This might be clear to you all, but not to me and probably not to some other eventual implementers either. Since this was a main point from Ian's, I wonder if we need to add some more guidance or details in here (not necessarily mentioning Vary etc.) |
|
I agree with @rmarx that we shouldn't remove the other paragraph and only replace it with this. |
| properties of an HTTP request it receives, the server is expected to control the | ||
| cacheability or the applicability of the cached response, by using header fields | ||
| that control the caching behavior (e.g., Cache-Control, Vary). | ||
| The sole intention of prioritization is to optimize how responses are being |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's the sole intention of prioritization. Don't we say you can use this to inform request behavior as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are trying to say that the intention of prioritization is to optimise HOW responses are being provided, not WHAT is provided. I started to walk this path in the introduction but didn't want to get too much into HTTP-core leet speak. IIUC what we are trying to say, I think we can riff off the following text fragments from the intro:
To provide meaningful representation of a document at the earliest
moment, it is important for an HTTP server to prioritize the HTTP
responses, or the chunks of those HTTP responses, that it sends.
This document defines the Priority HTTP header field that can be used
by both client and server to specify the precedence of HTTP responses
ianswett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, but I think this LG now.
Co-Authored-By: ianswett <[email protected]>
Co-Authored-By: ianswett <[email protected]>
ianswett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion
| The sole intention of prioritization is to optimize how responses are being | ||
| provided, not to change what is provided as the response. Therefore, a server MUST | ||
| NOT generate a different HTTP response based on the value of the Priority request | ||
| header field. Sending a cacheable response that depends on the Priority request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm finding this last sentence somewhat vague, how about:
"Sending a cacheable response including a Priority response header field that depends upon the Priority request header field is likely to lead to mis-prioritization when a cache reuses that response."
Forbid servers using the Priority request header to generate different responses, as suggested by @royfielding.