Fix dropdown options reflection error with kb-sdk validate
#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug found by the `kb_djornl` author: ``` Exception in thread "main" org.graalvm.nativeimage.MissingReflectionRegistrationError: The program tried to reflectively invoke method public us.kbase.narrativemethodstore.DropdownOptions() without it being registered for runtime reflection. * large stack trace with JsonClientCaller and Jackson methods snipped* at us.kbase.narrativemethodstore.NarrativeMethodStoreClient.validateMethod(NarrativeMethodStoreClient.java:526) at us.kbase.sdk.validator.ModuleValidator.validateMethodSpec(ModuleValidator.java:236) at us.kbase.sdk.validator.ModuleValidator.validate(ModuleValidator.java:168) at us.kbase.sdk.tester.ModuleTester.runTests(ModuleTester.java:94) at us.kbase.sdk.ModuleBuilder$TestCommand.call(ModuleBuilder.java:445) at us.kbase.sdk.ModuleBuilder$TestCommand.call(ModuleBuilder.java:431) at picocli.CommandLine.executeUserObject(CommandLine.java:2031) ``` Fixed this bug and other potential bugs around NMS classes not being fully accessible by making all methods, fields, and constructors available for reflection. Tested with the `kb_staging_exporter` app, which also has `dropdown_option` in `spec.json`, by running `kb-sdk validate`.
MrCreosote
commented
Jun 24, 2025
Comment on lines
-259
to
+265
| "--enable-url-protocols=https,http,file", | ||
| "--enable-url-protocols=https,http", |
There was a problem hiding this comment.
file is enabled by default
MrCreosote
commented
Jun 24, 2025
Comment on lines
-1056
to
-1060
| { | ||
| "name":"us.kbase.sdk.ModuleBuilder$ValidationArgs", | ||
| "allDeclaredFields":true, | ||
| "queryAllDeclaredMethods":true | ||
| }, |
There was a problem hiding this comment.
Removed in a previous PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=========================================
Coverage 69.04% 69.04%
Complexity 650 650
=========================================
Files 45 45
Lines 3609 3609
Branches 669 669
=========================================
Hits 2492 2492
Misses 868 868
Partials 249 249 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
build.gradle
Outdated
| echo "Done. NOTE: Inspect the merged output carefully; the agent is better" | ||
| echo "than starting from scratch but is imperfect." | ||
| echo "When merging into src/main/resources/META-INF/native-image carefully" | ||
| echo "check that" |
There was a problem hiding this comment.
supremely picky, but if you're going to have a bulleted list, it'd be better to precede it with a colon, e.g.
echo "When merging into src/main/resources/META-INF/native-image carefully"
echo "check the following:"
echo ""
Given the likely audience size for this codebase, though, it doesn't really matter.
Isn't it nice to have a comment on your PR so that you know someone somewhere cares?
ialarmedalien
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug found by the
kb_djornlauthor:Fixed this bug and other potential bugs around NMS classes not being fully accessible by making all methods, fields, and constructors available for reflection.
Tested with the
kb_staging_exporterapp, which also hasdropdown_optioninspec.json, by runningkb-sdk validate.