Make tests pass while prod catalog is down #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catalog just came up as I was running the test suite for the final time, but I'm pretty sure I caught everything.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
============================================
- Coverage 66.70% 65.96% -0.75%
+ Complexity 1455 1438 -17
============================================
Files 75 75
Lines 7017 7020 +3
Branches 1317 1318 +1
============================================
- Hits 4681 4631 -50
- Misses 1851 1896 +45
- Partials 485 493 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
briehl
approved these changes
Mar 17, 2025
| initer.initialize(useExample); | ||
| Assert.assertTrue(examineModule(SIMPLE_MODULE_NAME, useExample, lang)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testRModuleExample() throws Exception { |
There was a problem hiding this comment.
Ha, I forgot all about supporting R in the SDK.
There was a problem hiding this comment.
It was pretty half baked, no auth support for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catalog just came up as I was running the test suite for the final time, but I'm pretty sure I caught everything.
Fixes #50