Skip to content

Factor out FinishJobParams from the mock services #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

MrCreosote
Copy link
Member

Can't factor is out of module runner for now since module runner has 0 tests, sigh

Can't factor is out of module runner for now since module runner has 0
tests, sigh
Copy link

@ialarmedalien ialarmedalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are for losers anyway!

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.57%. Comparing base (9027203) to head (909950d).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/java/us/kbase/mobu/runner/FinishJobParams.java 0.00% 1 Missing ⚠️
src/java/us/kbase/mobu/runner/JsonRpcError.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #55      +/-   ##
============================================
- Coverage     65.96%   65.57%   -0.40%     
  Complexity     1438     1438              
============================================
  Files            75       77       +2     
  Lines          7020     7062      +42     
  Branches       1318     1318              
============================================
  Hits           4631     4631              
- Misses         1896     1938      +42     
  Partials        493      493              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCreosote MrCreosote merged commit 5401b52 into main Mar 17, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants