Remove kb-sdk compile --makefile argument
#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't do anything useful - the makefiles it generates are practically empty. `kb-sdk init` uses a dedicated template. Also tied up in async stuff which, via a long trail, leads back to the unnecessary `async` keyword in the kidl parser which should be removed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
============================================
- Coverage 65.60% 65.53% -0.07%
+ Complexity 1437 1424 -13
============================================
Files 77 77
Lines 7053 7005 -48
Branches 1315 1300 -15
============================================
- Hits 4627 4591 -36
+ Misses 1935 1931 -4
+ Partials 491 483 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ialarmedalien
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't do anything useful - the makefiles it generates are practically empty.
kb-sdk inituses a dedicated template.Also tied up in async stuff which, via a long trail, leads back to the unnecessary
asynckeyword in the kidl parser which should be removed.