Skip to content

Remove kb-sdk compile --makefile argument#60

Merged
MrCreosote merged 1 commit intomainfrom
sdkdev
Mar 21, 2025
Merged

Remove kb-sdk compile --makefile argument#60
MrCreosote merged 1 commit intomainfrom
sdkdev

Conversation

@MrCreosote
Copy link
Member

Doesn't do anything useful - the makefiles it generates are practically empty. kb-sdk init uses a dedicated template.

Also tied up in async stuff which, via a long trail, leads back to the unnecessary async keyword in the kidl parser which should be removed.

Doesn't do anything useful - the makefiles it generates are practically
empty. `kb-sdk init` uses a dedicated template.

Also tied up in async stuff which, via a long trail, leads back to the
unnecessary `async` keyword in the kidl parser which should be removed.
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.53%. Comparing base (7268322) to head (94ca75c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...java/us/kbase/mobu/compiler/RunCompileCommand.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #60      +/-   ##
============================================
- Coverage     65.60%   65.53%   -0.07%     
+ Complexity     1437     1424      -13     
============================================
  Files            77       77              
  Lines          7053     7005      -48     
  Branches       1315     1300      -15     
============================================
- Hits           4627     4591      -36     
+ Misses         1935     1931       -4     
+ Partials        491      483       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCreosote MrCreosote merged commit be954c3 into main Mar 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants