Remove the KIDL async keyword
#61
Conversation
Replaced years ago by specifying async status on the command line when compiling or automatically getting it from the catalog for kb-sdk install
There was a problem hiding this comment.
Everything in this folder except for SpecParser.jj is generated by javacc
| boolean anyAsync = asyncVersion != null || anyAsync(module); | ||
| boolean anyAsync = asyncVersion != null; |
There was a problem hiding this comment.
This method is 500 or so lines long, so the next 3 anyAsync bools are coming from here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
============================================
- Coverage 65.53% 65.43% -0.11%
+ Complexity 1424 1401 -23
============================================
Files 77 77
Lines 7005 6940 -65
Branches 1300 1283 -17
============================================
- Hits 4591 4541 -50
+ Misses 1931 1921 -10
+ Partials 483 478 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (asyncByDefault) { | ||
| // Make all methods async and mark methods being async already as couldn't be sync | ||
| context.put("any_async", true); | ||
| List<Map<String, Object>> modules = (List<Map<String, Object>>)context.get("modules"); | ||
| for (int modulePos = 0; modulePos < modules.size(); modulePos++) { | ||
| Map<String, Object> module = modules.get(modulePos); | ||
| module.put("any_async", true); | ||
| List<Map<String, Object>> methods = (List<Map<String, Object>>)module.get("methods"); | ||
| if (methods == null) | ||
| continue; | ||
| for (int methodPos = 0; methodPos < methods.size(); methodPos++) { | ||
| Map<String, Object> method = methods.get(methodPos); | ||
| //TODO ROMAN should async go into the map or can this line be deleted? | ||
| // Boolean async = (Boolean)method.get("async"); | ||
| method.put("async", true); | ||
| //if (async == null || !async) | ||
| // method.put("could_be_sync", true); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This section has no effect, since none of the keys it adds to the map are used in the python server or impl files. Not sure about the other languages but they're being removed anyway
| @@ -104,7 +103,6 @@ public static void generate(List<KbService> srvs, String defaultUrl, | |||
| jsClient.close(); | |||
| } | |||
| Map<String, Object> perlMakefileContext = new LinkedHashMap<String, Object>(context); | |||
| Map<String, Object> pyMakefileContext = new LinkedHashMap<String, Object>(context); | |||
There was a problem hiding this comment.
Cruft I missed on an earlier PR
| async, clientAsyncVer, dynservVer, semanticVersion, gitUrl, gitCommitHash); | ||
| clientAsyncVer, dynservVer, semanticVersion, gitUrl, gitCommitHash); |
There was a problem hiding this comment.
If async is true at this point clientAsyncVer is guaranteed not to be null
Replaced years ago by specifying async status on the command line when compiling or automatically getting it from the catalog for kb-sdk install
Note there's some whitespace changes