Refactor template generation code out of the KIDL parser #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't belong there - the KIDL parser should parse KIDL and nothing more. The template generation code has been moved into a KIDL Visitor class in the same package as the `TemplateBasedGenerator`. The code is mostly C&P other than changes to allow for the fact the code no longer has access to instance variables and use the visitor pattern where possible (which isn't much w/o making drastic changes). Tested by generating the template structure with the code in the visitor and the code in the `forTemplates` methods before deleting said methods, and throwing an exception if they weren't `equals()`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
============================================
+ Coverage 65.43% 65.51% +0.07%
- Complexity 1401 1410 +9
============================================
Files 77 78 +1
Lines 6940 6953 +13
Branches 1283 1284 +1
============================================
+ Hits 4541 4555 +14
+ Misses 1921 1920 -1
Partials 478 478 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ialarmedalien
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't belong there - the KIDL parser should parse KIDL and nothing more. The template generation code has been moved into a KIDL Visitor class in the same package as the
TemplateBasedGenerator.The code is mostly C&P other than changes to allow for the fact the code no longer has access to instance variables and use the visitor pattern where possible (which isn't much w/o making drastic changes).
Tested by generating the template structure with the code in the visitor and the code in the
forTemplatesmethods before deleting said methods, and throwing an exception if they weren'tequals().