Factor Tuple2 out of the codebase #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...prior to transferring KIDL code to the java_kidl repo, since that doesn't have tuple2 class and it's easy enough to make a 2 items class to replace it anyway
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
============================================
+ Coverage 65.51% 65.54% +0.02%
Complexity 1410 1410
============================================
Files 78 78
Lines 6953 6959 +6
Branches 1284 1284
============================================
+ Hits 4555 4561 +6
Misses 1920 1920
Partials 478 478 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
briehl
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...prior to transferring KIDL code to the java_kidl repo, since that doesn't have tuple2 class and it's easy enough to make a 2 item class to replace it anyway