Skip to content

Move utility methods out of KIDL that aren't used there #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

MrCreosote
Copy link
Member

Post parse utility functions belong in SDK code, not in KIDL code. The moved functions are not called anywhere in KIDL code

Post parse utility functions belong in SDK code, not in KIDL code. The
moved functions are not called anywhere in KIDL code
@MrCreosote MrCreosote requested a review from briehl March 27, 2025 16:29
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 83.96226% with 17 lines in your changes missing coverage. Please review.

Project coverage is 65.53%. Comparing base (91e680d) to head (166fe43).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/java/us/kbase/mobu/compiler/Utils.java 83.96% 6 Missing and 11 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #66      +/-   ##
============================================
- Coverage     65.54%   65.53%   -0.01%     
  Complexity     1410     1410              
============================================
  Files            78       79       +1     
  Lines          6959     6960       +1     
  Branches       1284     1284              
============================================
  Hits           4561     4561              
- Misses         1920     1921       +1     
  Partials        478      478              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@briehl briehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some solid copy-and-pasting to me.

@MrCreosote MrCreosote merged commit 6fba0df into main Mar 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants