Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpstan level 6 #425

Merged
merged 10 commits into from
Oct 8, 2024
Merged

Phpstan level 6 #425

merged 10 commits into from
Oct 8, 2024

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Jul 10, 2024

This PR improves the code to pass PHPStan level 6.

@Art4 Art4 added this to the v2.8.0 milestone Jul 10, 2024
@Art4 Art4 self-assigned this Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (5dbf37a) to head (7871ae1).
Report is 11 commits behind head on v2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #425   +/-   ##
=========================================
  Coverage     98.60%   98.60%           
  Complexity      657      657           
=========================================
  Files            29       29           
  Lines          2001     2001           
=========================================
  Hits           1973     1973           
  Misses           28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 marked this pull request as ready for review October 8, 2024 11:36
@Art4 Art4 merged commit acb5589 into kbsali:v2.x Oct 8, 2024
12 checks passed
@Art4 Art4 deleted the phpstan-level-6 branch October 8, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant