update test context.WithCancel with testing.T.Context

[olamilekan000]

Summary

change replaces context.WithCancel with testing.T.Context

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Fixes #

Release Notes

NONE

[kcp-ci-bot]

Hi @olamilekan000. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ntnn]

Please replace uses of ctx with t.Context() - cases where we used ctx, cancel := ... was only due to needing access to cancel.

[olamilekan000]

There's only one occurance of context.WithCancelCause at the moment and the reason it wasn't changed is because the cancel function is being assigned as a field in authenticatorState.

	c.authConfigAuthenticators[shard][mapKey] = authenticatorState{
		cancel:        cancel,
		authenticator: authn,
	}

should it be removed?

[xrstf]

The cancel func needs to remain in the authState, or else the front-proxy will not be able to stop OIDC authenticators at runtime. But this should not affect this test function at all.

I would say you changed this test function here exactly as expected.

[olamilekan000]

Actually, the part of the code I shared doesn't need to change. There are no longer usage of context.WithCancelCause for test in this branch.

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign embik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS
• config/crds/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mjudeikis]

/ok-to-test

[olamilekan000]

/retest

[mjudeikis]

lint failure looks leggit

[olamilekan000]

/retest

[kcp-ci-bot]

@olamilekan000: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kcp-lint	0386116	link	true	/test pull-kcp-lint
pull-kcp-test-e2e-sharded	0386116	link	true	/test pull-kcp-test-e2e-sharded
pull-kcp-test-e2e-shared	0386116	link	true	/test pull-kcp-test-e2e-shared
pull-kcp-test-e2e	0386116	link	true	/test pull-kcp-test-e2e
pull-kcp-test-e2e-multiple-runs	0386116	link	true	/test pull-kcp-test-e2e-multiple-runs

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[kcp-ci-bot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ntnn]

Superseded by #3795