Fix dependencies for the cli staging repo#3702
Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom Nov 6, 2025
Merged
Conversation
On-behalf-of: @SAP marko.mudrinic@sap.com Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kcp-ci-bot
added
the
release-note-none
kcp-ci-bot
added
dco-signoff: yes
Contributor
|
LGTM label has been added. DetailsGit tree hash: 3ce9436211cd7363d57e7ef72a172bf603d8c810 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Member
Author
|
/test pull-kcp-test-e2e-sharded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It turns out that you have to specify dependencies of dependencies in the publishing-bot rules otherwise publishing-bot would fail to update direct dependencies. That's because those direct dependencies are already updated to the latest tag, and when some repo tries to pull that updated direct dependency, that fails because dependencies of direct dependency are updated.
Why that happens: it's because publishing-bot does not push to GitHub until the very end of the process. Instead, it creates modules and puts them to the cache (
$GOPATH/pkg/mod/cache/download) manually, so commands suchgo mod downloadactually work. But for this, you need to also setGOPRIVATEenvironment variables to a list of repositories that are not yet publicly available. publishing-bot generates the value ofGOPRIVATEbased on specified dependencies, and that's why you have to provide all dependencies and not only direct dependencies.A good example of that in upstream is
sample-cli-plugin:What Type of PR Is This?
/kind chore
Release Notes
/assign @xrstf @embik