Skip to content

make initializer and terminator workspace URLs distinguishable #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make initializer and terminator workspace URLs distinguishable #3707

wants to merge 1 commit into from

Conversation

@olamilekan000
Copy link
Contributor

@olamilekan000 olamilekan000 commented Nov 8, 2025

Summary

change adds a type field to the VirtualWorkspace api schema to make the initializer and terminator workspace URLs distinguishable.
Screenshot 2025-11-08 at 02 01 25

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes 3699

Release Notes

Adds a `type` field to the VirtualWorkspace API schema to distinguish between initializing and terminating workspace URLs.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 8, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Nov 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mjudeikis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olamilekan000 olamilekan000 requested a review from embik November 8, 2025 01:06
@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2025
@olamilekan000 olamilekan000 requested review from SimonTheLeg and removed request for embik November 8, 2025 01:06
@kcp-ci-bot kcp-ci-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 8, 2025
@olamilekan000 olamilekan000 force-pushed the differentiate-btw-terminator-and-intializer branch from e555bef to 9600d2a Compare November 8, 2025 01:51
@olamilekan000 olamilekan000 force-pushed the differentiate-btw-terminator-and-intializer branch from 9600d2a to 8025026 Compare November 8, 2025 01:53
@olamilekan000
Copy link
Contributor Author

olamilekan000 commented Nov 8, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonTheLeg SimonTheLeg Awaiting requested review from SimonTheLeg

@embik embik Awaiting requested review from embik

@astefanutti astefanutti Awaiting requested review from astefanutti

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make terminator and initializer VirtualWorkspace URLs distinguishable

2 participants

@olamilekan000 @kcp-ci-bot