Skip to content

Use non-versioned modules for staging repo dependencies #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2025
Merged

Use non-versioned modules for staging repo dependencies #3708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions docs/generators/cli-doc/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,21 @@ module github.com/kcp-dev/kcp/docs/generators/cli-doc
go 1.24.0

require (
github.com/kcp-dev/kcp v0.0.0-00010101000000-000000000000
github.com/kcp-dev/cli v0.0.0-00010101000000-000000000000
github.com/kcp-dev/cli v0.0.0
github.com/kcp-dev/kcp v0.0.0
github.com/spf13/cobra v1.9.1
)

replace (
github.com/charmbracelet/colorprofile => github.com/charmbracelet/colorprofile v0.2.2
github.com/charmbracelet/x/ansi => github.com/charmbracelet/x/ansi v0.8.0
)

replace (
github.com/kcp-dev/apimachinery/v2 => ../../../staging/src/github.com/kcp-dev/apimachinery
github.com/kcp-dev/cli => ../../../staging/src/github.com/kcp-dev/cli
github.com/kcp-dev/client-go => ../../../staging/src/github.com/kcp-dev/client-go
github.com/kcp-dev/code-generator/v3 => ../../../staging/src/github.com/kcp-dev/code-generator
github.com/kcp-dev/kcp => ../../../
github.com/kcp-dev/sdk => ../../../staging/src/github.com/kcp-dev/sdk
)
Expand Down Expand Up @@ -48,8 +54,8 @@ require (
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/kcp-dev/apimachinery/v2 v2.0.1-0.20250728122101-adbf20db3e51 // indirect
github.com/kcp-dev/sdk v0.0.0-00010101000000-000000000000 // indirect
github.com/kcp-dev/logicalcluster/v3 v3.0.5 // indirect
github.com/kcp-dev/sdk v0.0.0 // indirect
github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de // indirect
github.com/lucasb-eyer/go-colorful v1.3.0 // indirect
github.com/mailru/easyjson v0.9.0 // indirect
Expand Down
4 changes: 0 additions & 4 deletions docs/generators/cli-doc/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ github.com/josharian/intern v1.0.0 h1:vlS4z54oSdjm0bgjRigI+G1HpF+tI+9rE5LLzOg8Hm
github.com/josharian/intern v1.0.0/go.mod h1:5DoeVV0s6jJacbCEi61lwdGj/aVlrQvzHFFd8Hwg//Y=
github.com/json-iterator/go v1.1.12 h1:PV8peI4a0ysnczrg+LtxykD8LfKY9ML6u2jnxaEnrnM=
github.com/json-iterator/go v1.1.12/go.mod h1:e30LSqwooZae/UwlEbR2852Gd8hjQvJoHmT4TnhNGBo=
github.com/kcp-dev/apimachinery/v2 v2.0.1-0.20250728122101-adbf20db3e51 h1:l38RDS+VUMx9etvyaCgJIZa4nM7FaNevNubWN0kDZY4=
github.com/kcp-dev/apimachinery/v2 v2.0.1-0.20250728122101-adbf20db3e51/go.mod h1:rF1jfvUfPjFXs+HV/LN1BtPzAz1bfjJOwVa+hAVfroQ=
github.com/kcp-dev/client-go v0.0.0-20250728134101-0355faa9361b h1:2LGrXvY9sc4l5yjKIbMZ86GEou7NyrHhA4qBPaeFfxs=
github.com/kcp-dev/client-go v0.0.0-20250728134101-0355faa9361b/go.mod h1:QdO8AaGAZPr/rIZ1iVanCM3tUOiiuX897GWv7WTByLE=
github.com/kcp-dev/logicalcluster/v3 v3.0.5 h1:JbYakokb+5Uinz09oTXomSUJVQsqfxEvU4RyHUYxHOU=
github.com/kcp-dev/logicalcluster/v3 v3.0.5/go.mod h1:EWBUBxdr49fUB1cLMO4nOdBWmYifLbP1LfoL20KkXYY=
github.com/kisielk/errcheck v1.5.0/go.mod h1:pFxgyoBC7bSaBwPgfKdkLd5X25qrDl4LWUI2bnpBCr8=
Expand Down
6 changes: 3 additions & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ require (
github.com/google/go-cmp v0.7.0
github.com/google/uuid v1.6.0
github.com/kcp-dev/apimachinery/v2 v2.0.1-0.20250728122101-adbf20db3e51
Copy link
Member Author

@xmudrii xmudrii Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware that this is not non-versioned import, but I'm not able to turn it into v2.0.0-00010101000000-000000000000 (go mod tidy reverts back to this version). I assume this is because github.com/kcp-dev/apimachinery/v2 is a dependency in kcp-dev/kubernetes which we import here (go mod why tells nothing, but some search magic uncovers this ✨).

Nonetheless, this is the main/root module and it's not that important, so we just leave it as it is. There's anyways replace directive for it below.

github.com/kcp-dev/client-go v0.0.0-20250728134101-0355faa9361b
github.com/kcp-dev/code-generator/v3 v3.0.0-20250728122101-5b4ff5c24054
github.com/kcp-dev/client-go v0.0.0
github.com/kcp-dev/code-generator/v3 v3.0.0-00010101000000-000000000000
github.com/kcp-dev/embeddedetcd v1.0.3-0.20250805142358-a4839a83564a
github.com/kcp-dev/logicalcluster/v3 v3.0.5
github.com/kcp-dev/sdk v0.0.0-00010101000000-000000000000
github.com/kcp-dev/sdk v0.0.0
github.com/martinlindhe/base36 v1.1.1
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822
github.com/prometheus/client_golang v1.22.0
Expand Down
6 changes: 3 additions & 3 deletions staging/src/github.com/kcp-dev/cli/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ require (
github.com/charmbracelet/bubbletea v1.3.10
github.com/charmbracelet/lipgloss v1.1.0
github.com/google/go-cmp v0.7.0
github.com/kcp-dev/client-go v0.0.0-20250728134101-0355faa9361b
github.com/kcp-dev/client-go v0.0.0
github.com/kcp-dev/logicalcluster/v3 v3.0.5
github.com/kcp-dev/sdk v0.0.0-00010101000000-000000000000
github.com/kcp-dev/sdk v0.0.0
github.com/spf13/cobra v1.9.1
github.com/spf13/pflag v1.0.6
github.com/stretchr/testify v1.10.0
Expand Down Expand Up @@ -49,7 +49,7 @@ require (
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/kcp-dev/apimachinery/v2 v2.0.0-20250728122101-adbf20db3e51 // indirect
github.com/kcp-dev/apimachinery/v2 v2.0.0-00010101000000-000000000000 // indirect
github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de // indirect
github.com/lucasb-eyer/go-colorful v1.3.0 // indirect
github.com/mailru/easyjson v0.9.0 // indirect
Expand Down
4 changes: 2 additions & 2 deletions staging/src/github.com/kcp-dev/client-go/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ go 1.24.0

require (
github.com/google/gnostic-models v0.6.9
github.com/kcp-dev/apimachinery/v2 v2.0.0-20250717064240-78e565b4a69a
github.com/kcp-dev/code-generator/v3 v3.0.0-20250717064843-0c8e5fec4f71
github.com/kcp-dev/apimachinery/v2 v2.0.0-00010101000000-000000000000
github.com/kcp-dev/code-generator/v3 v3.0.0-00010101000000-000000000000
github.com/kcp-dev/logicalcluster/v3 v3.0.5
gopkg.in/evanphx/json-patch.v4 v4.12.0
k8s.io/api v0.33.3
Expand Down
5 changes: 3 additions & 2 deletions staging/src/github.com/kcp-dev/code-generator/examples/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ go 1.24.0
replace acme.corp/pkg => ./pkg

require (
github.com/kcp-dev/apimachinery/v2 v2.0.1-0.20250717064240-78e565b4a69a
github.com/kcp-dev/client-go v0.0.0-20250721105427-d4a93d7c5fc9
github.com/kcp-dev/apimachinery/v2 v2.0.0-00010101000000-000000000000
github.com/kcp-dev/client-go v0.0.0
github.com/kcp-dev/logicalcluster/v3 v3.0.5
k8s.io/apimachinery v0.33.3
k8s.io/client-go v0.33.3
Expand Down Expand Up @@ -55,4 +55,5 @@ require (
replace (
github.com/kcp-dev/apimachinery/v2 => ../../apimachinery
github.com/kcp-dev/client-go => ../../client-go
github.com/kcp-dev/code-generator/v3 => ../../code-generator
)
4 changes: 2 additions & 2 deletions staging/src/github.com/kcp-dev/sdk/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ require (
github.com/egymgmbh/go-prefix-writer v0.0.0-20180609083313-7326ea162eca
github.com/go-logr/logr v1.4.2
github.com/google/go-cmp v0.7.0
github.com/kcp-dev/apimachinery/v2 v2.0.0-20250728122101-adbf20db3e51
github.com/kcp-dev/client-go v0.0.0-20250728134101-0355faa9361b
github.com/kcp-dev/apimachinery/v2 v2.0.0-00010101000000-000000000000
github.com/kcp-dev/client-go v0.0.0
github.com/kcp-dev/logicalcluster/v3 v3.0.5
github.com/martinlindhe/base36 v1.1.1
github.com/muesli/reflow v0.3.0
Expand Down