apiexport: watch APIExportEndpointSlice dynamically
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/XL
embik
changed the title
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
apiexport-provider-endpointslice
branch
from
551c506 to
2aa121e
Compare
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
embik
changed the title
APIExportEndpointSlice dynamically
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the
apiexportprovider with a breaking change: It no longer requires a REST config pointing to a virtual workspace endpoint for anAPIExport, instead it now requires anAPIExportEndpointSlicename passed as a mandatory parameter forapiexport.New.The new version of the provider watches all URLs in the endpoint slice status and automatically starts and stops an internal provider implementation (which is actually the previous provider implementation) through @ntnn's
multiprovider.The provider stops when the
APIExportEndpointSlicegets deleted, since that didn't seem like an event to handle gracefully in another way. Stopping it should have it covered by automatic restarts for self-healing (if the endpoint slice object gets put back).What Type of PR Is This?
/kind feature
/kind api-change
Related Issue(s)
Fixes #48
Release Notes