Skip to content

Conversation

@xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 6, 2025

What it says in the title, there's a bunch of go mod edit commands that expect the full package name including the module major version.

/assign @xrstf @embik

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2025
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@kcp-ci-bot
Copy link

LGTM label has been added.

Git tree hash: 3123643b2556bddd127f85f227ff3e55e9fc7465

@kcp-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2025
@xmudrii
Copy link
Member Author

xmudrii commented Nov 6, 2025

/hold

@kcp-ci-bot kcp-ci-bot merged commit 258df65 into kcp-dev:master Nov 6, 2025
6 checks passed
@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@xmudrii xmudrii deleted the fix-go-mod-edit branch November 6, 2025 14:03
@xmudrii xmudrii removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants