small fix in ImageGeneticAdversarialGeneratorLatent generator#11
Open
rafaporci wants to merge 1 commit intokdd-lab:mainfrom
Open
small fix in ImageGeneticAdversarialGeneratorLatent generator#11rafaporci wants to merge 1 commit intokdd-lab:mainfrom
rafaporci wants to merge 1 commit intokdd-lab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While experimenting ABELE explainer I found this potential issue in the ImageGeneticAdversarialGeneratorLatent generator. After the generation balancing made by the _balance_neigh method, in the attempt to adjust the Z array type, this line overrides it with the former array (before balancing). It creates problems when the balance _balance_neigh adds new samples to balance the generation.
I believe this line would only make sense with the line
# lZ_img, Z_img, Yb = self._fix_neigh(lZ_img, Z_img, Yb, class_value)uncommented.What do you think?