Skip to content

Remove unused UI elements #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2015
Merged

Remove unused UI elements #16

merged 2 commits into from
Nov 27, 2015

Conversation

kdzwinel
Copy link
Owner

(preserve log, clear cache, screencapture, clear cookies, hide data URLs).

Sadly, there was no config to disable these elements. I'm still not sure if removing them from the DT code is the best way to hide them. Updating DT code in the future will get complicated. On the other hand, hiding them via display:none seems like a hack + it'd be hard to target all these elements via CSS (e.g. context menu).

Preview:
betwixt-ui

Fixes #5

@kdzwinel kdzwinel force-pushed the 5-remove-ui-elements branch from 95dd9ef to 91401fa Compare November 26, 2015 00:04
@samccone
Copy link
Collaborator

we should kill throttling also right?

@kdzwinel
Copy link
Owner Author

I thought about keeping it for #9, but you are right, let's kill it until it's actually needed. Showing it back again would be a matter of reverting my last commit here.

@portellaa
Copy link
Contributor

Wouldn't be great to have a preference panel to configure which menus/panels the user wants to use? Doesn't knows if makes sense or is so useful that worths the work.

@samccone
Copy link
Collaborator

hey @portellaa if these UI elements were functional it would be useful, however these UI elements are non-functional at the moment so hiding them is probably a decent idea :)

@kdzwinel
Copy link
Owner Author

IMO most of these UI elements didn't make much sense in the context of Betwixt (e.g. there is no cache or cookies that we can clear). Throttling will be back as soon as it will be implemented (see #9).

@kdzwinel
Copy link
Owner Author

I hear no objections so I'm merging 💥

kdzwinel added a commit that referenced this pull request Nov 27, 2015
@kdzwinel kdzwinel merged commit bee1188 into master Nov 27, 2015
@kdzwinel kdzwinel deleted the 5-remove-ui-elements branch November 27, 2015 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants