Merged
Conversation
hosekpeter
force-pushed
the
petr-hosek-PSGO-726
branch
10 times, most recently
from
e38ded8 to
17003d4
Compare
hosekpeter
force-pushed
the
petr-hosek-PSGO-726
branch
from
17003d4 to
12243fa
Compare
hosekpeter
commented
Apr 17, 2025
hosekpeter
commented
Apr 17, 2025
Contributor
Author
hosekpeter
requested review from
Matovidlo and
jachym-tousek-keboola
as code owners
Matovidlo
reviewed
Apr 17, 2025
Contributor
Matovidlo
left a comment
Matovidlo
left a comment
There was a problem hiding this comment.
For some reason we stopped using the S3 bucket, now we have GH cache which we do not need to clean at all it has it's own lifecycle.
This cleanup is needed only for S3 bucket this gh cache cleanup is done automatically
Contributor
Author
|
@Matovidlo I read somewhere the GitHub cache cleaner can't to remove the duplicate keys. You can set up it in the own workflow. It is not by default. |
hosekpeter
force-pushed
the
petr-hosek-PSGO-726
branch
3 times, most recently
from
7c7b4e6 to
d92816d
Compare
jachym-tousek-keboola
approved these changes
Apr 23, 2025
Matovidlo
approved these changes
Apr 23, 2025
Contributor
Matovidlo
left a comment
Matovidlo
left a comment
There was a problem hiding this comment.
LGTM. We need to take a look on caching using S3 as this cache is overloaded.
Typically it is 24-48 hours present
Co-authored-by: Jáchym Toušek <jachym.tousek@keboola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new workflow for cleaning up GitHub Actions caches and includes documentation to explain its purpose and usage. The workflow aims to manage cache growth by removing old and duplicate entries, improving efficiency and reducing disk usage.
Workflow Implementation:
.github/workflows/gh-cache-cleanup.yml, to automate GitHub Actions cache cleanup. It includes features such as scheduled weekly and monthly cleanups, cache deduplication, and a dry-run mode for safe testing.Documentation:
docs/github-actions-cache-cleanup.mdto describe the problem of cache growth, the solution provided by the new workflow, and detailed instructions for configuration, usage, and testing.Jira: XXXXXChanges: