Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for http header routing #1183

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gjreasoner
Copy link

Adds support for #1177, http header based routing pattern.

Checklist

Fixes #1177

@gjreasoner gjreasoner marked this pull request as ready for review October 28, 2024 17:55
@gjreasoner gjreasoner requested a review from a team as a code owner October 28, 2024 17:55
Signed-off-by: Justin Reasoner <[email protected]>
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for contributing!

Before we move forward, I'd like to propose an alternative path for configuring the headers routing as part of the HTTPScaledObject CRD. Imho it would allow more flexibility if both, the header name as well as header value, could be configured together, similar to how rule matches are defined in HTTPRoutes in Gateway API

For example:

apiVersion: http.keda.sh/v1alpha1
kind: HTTPScaledObject
spec:
  hosts:
  - my.domain.com
  - my2.domain.com
  pathPrefixes:
  - /root
  - /new-feature
  headers:
  - name: x-header-test
    value: abc
  - name: x-header-test2
    value: def

xref #1177 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http header routing pattern
2 participants