docs: Allow TriggerAuthentication Defaults via ENV variables for HashiCorp Vault #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bojan Zelic <[email protected]>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
Signed-off-by: Bojan Zelic <[email protected]>
Closed
4 tasks
tomkerkhove
changed the title
tomkerkhove
reviewed
Nov 21, 2023
| authentication: token | kubernetes # Required. | ||
| role: {hashicorp-vault-role} # Optional. | ||
| mount: {hashicorp-vault-mount} # Optional. | ||
| address: {hashicorp-vault-address} # Optional. (env - $VAULT_ADDR) |
There was a problem hiding this comment.
@JorTurFer Is this the format we usually use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets vault defaults if specified via ENV variables. When configuring the operator, you can set ENV variables so users don't have to redefine vault settings every time they use vault authentication;
Checklist
Fixes # kedacore/keda#4965
Relates To: kedacore/keda#5196