Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beanstalkd scaler docs #1454

Merged
merged 11 commits into from
Nov 5, 2024
Merged

Add beanstalkd scaler docs #1454

merged 11 commits into from
Nov 5, 2024

Conversation

sbarnesthornton
Copy link
Contributor

@sbarnesthornton sbarnesthornton commented Aug 15, 2024

Adds docs regarding the beanstalkd scaler introduced in #5901.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#5901
Relates to kedacore/keda#6081

Signed-off-by: Sam Barnes-Thornton <[email protected]>
@sbarnesthornton sbarnesthornton requested a review from a team as a code owner August 15, 2024 16:21
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 833d6de
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/672a7bbd24069f0008e6e931
😎 Deploy Preview https://deploy-preview-1454--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sam Barnes-Thornton added 2 commits August 15, 2024 16:29
Signed-off-by: Sam Barnes-Thornton <[email protected]>
Signed-off-by: Sam Barnes-Thornton <[email protected]>
Signed-off-by: Sam Barnes-Thornton <[email protected]>
content/docs/2.15/scalers/beanstalkd.md Outdated Show resolved Hide resolved
Signed-off-by: Sam Barnes-Thornton <[email protected]>
@sbarnesthornton
Copy link
Contributor Author

The test deployment preview is failing after I have changed the version to be 2.16, which seems potentially something to do with caching as it is still looking for the docs in 2.15. I'm not sure how to sort this, but it was working before the move to 2.16.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

Could you add the page to this file? https://github.com/kedacore/keda-docs/blob/main/.htmltest.yml

As the scaler doesn't appear in v2.15, the links checker is detecting it as failure

Signed-off-by: Sam Barnes-Thornton <[email protected]>
@sbarnesthornton
Copy link
Contributor Author

Page has been added to the test ignores file as instructed. Deploy tests all seem to pass now, so should be good to go. Thanks for all the help 😄

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/docs/2.16/scalers/beanstalkd.md Outdated Show resolved Hide resolved
@zroubalik zroubalik merged commit a94044d into kedacore:main Nov 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants