Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add link-checking workflow #1459

Merged

Conversation

nate-double-u
Copy link
Contributor

Adding a github workflow to run the link checker on PR.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #667

@nate-double-u nate-double-u requested a review from a team as a code owner August 22, 2024 01:15
@nate-double-u nate-double-u marked this pull request as draft August 22, 2024 01:15
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 60530d8
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/671fa61331f5d700083ea262
😎 Deploy Preview https://deploy-preview-1459--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nate-double-u nate-double-u force-pushed the 667-provide-ci-check-to-verify-links branch 2 times, most recently from 4907119 to e5003e4 Compare August 22, 2024 01:41
@nate-double-u nate-double-u changed the title adding link checking workflow for CI updating link checking workflow for CI Aug 22, 2024
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're close, but there are a few issues that we can tackle incrementally. For a first iteration of fixes, see the inline comments.

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@chalin chalin changed the title updating link checking workflow for CI [CI] Add link-checking workflow Aug 29, 2024
@chalin chalin force-pushed the 667-provide-ci-check-to-verify-links branch from 8c78309 to 7e994f6 Compare August 29, 2024 21:07
@nate-double-u
Copy link
Contributor Author

Updated, now failing condition looks to be working:
Screenshot 2024-10-18 at 1 23 23 PM

Now removing edit to test failure condition, next push should build correctly.

@nate-double-u
Copy link
Contributor Author

Build working, no broken links found, github action doing the reporting in both passing and failing scenarios.

Screenshot 2024-10-18 at 1 27 48 PM

Next push rebases this branch to bring this branch up to date with main.

@nate-double-u nate-double-u force-pushed the 667-provide-ci-check-to-verify-links branch from 4bf283f to a11eda5 Compare October 18, 2024 20:33
@nate-double-u
Copy link
Contributor Author

This is ready for review now. Thanks for the help @chalin!

@nate-double-u nate-double-u marked this pull request as ready for review October 18, 2024 20:34
@nate-double-u
Copy link
Contributor Author

/cc @tomkerkhove @wozniakjan

@wozniakjan wozniakjan requested a review from a team October 24, 2024 06:53
@JorTurFer
Copy link
Member

nice job! Thanks 🙇

@JorTurFer JorTurFer merged commit a7791ca into kedacore:main Nov 3, 2024
8 checks passed
@nate-double-u nate-double-u deleted the 667-provide-ci-check-to-verify-links branch November 3, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide CI check to verify links
3 participants