Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Promote Scaling Modifiers to GA #1460

Merged
merged 3 commits into from
Aug 27, 2024
Merged

chore: Promote Scaling Modifiers to GA #1460

merged 3 commits into from
Aug 27, 2024

Conversation

JorTurFer
Copy link
Member

No description provided.

@JorTurFer JorTurFer requested a review from a team as a code owner August 27, 2024 13:42
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 73b3f3b
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66cdd89b205399000897b35c
😎 Deploy Preview https://deploy-preview-1460--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

zroubalik
zroubalik reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here: https://keda.sh/docs/2.15/reference/scaledobject-spec/#scalingmodifiers

@JorTurFer
Copy link
Member Author

Also here: keda.sh/docs/2.15/reference/scaledobject-spec#scalingmodifiers

nice catch! updated

@JorTurFer JorTurFer enabled auto-merge (squash) August 27, 2024 13:51
@JorTurFer JorTurFer merged commit 4c95c44 into kedacore:main Aug 27, 2024
7 checks passed
@JorTurFer JorTurFer deleted the promote-scaling branch August 28, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JorTurFer @zroubalik