Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify pollingInterval and Caching Metrics #1483

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Clarify pollingInterval and Caching Metrics #1483

merged 2 commits into from
Nov 5, 2024

Conversation

rickbrouwer
Copy link
Contributor

  • Clarified pollingInterval.
  • Added a reference to the triggers page for Caching Metrics to clarify which feature can be used.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1482

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 9, 2024 06:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 86e1f58
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/670627f85ede110008059149
😎 Deploy Preview https://deploy-preview-1483--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

zroubalik
zroubalik approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like this a lot!

@zroubalik zroubalik merged commit 9bbd7bf into kedacore:main Nov 5, 2024
8 checks passed
@rickbrouwer rickbrouwer deleted the pollinginterval branch November 6, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify pollingInterval and Caching Metrics
2 participants
@rickbrouwer @zroubalik