feat: nsq scaler docs #1485
Open
feat: nsq scaler docs #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Oct 14, 2024
Ulminator
force-pushed
the
nsq_scaler_docs
branch
4 times, most recently
from
bdefcc5
to
9bfd393
Compare
Signed-off-by: Matt Ulmer <[email protected]>
Signed-off-by: Matt Ulmer <[email protected]>
Ulminator
force-pushed
the
nsq_scaler_docs
branch
from
4dc2699
to
ce3f01c
Compare
JorTurFer
approved these changes
Nov 5, 2024
zroubalik
reviewed
Nov 5, 2024
content/docs/2.16/scalers/nsq.md
Outdated
|
|
||
|
|
||
| > **Notice:** | ||
| > - Since ["channels are created on first use by subscribing to the named channel"](https://nsq.io/overview/design.html#simplifying-configuration-and-administration), the topic depth is used instead of the channel depth when the channel does not yet exist on an [nsqd](https://nsq.io/components/nsqd.html) instance. This allows KEDA to effectively bootstrap new channels when the `idleReplicaCount` is 0. |
There was a problem hiding this comment.
is it really idleReplicaCount here or should it be more generic minReplicaCount?
There was a problem hiding this comment.
It looks like minReplicaCount makes more sense, making a quick fix 👍
Signed-off-by: Matt Ulmer <[email protected]>
6 tasks
Signed-off-by: Matt Ulmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
nsqscaler documentation for v2.16 release.Checklist
Relates to: