-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for scaling based on Redis Key-Values #1493
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: wangrushen <[email protected]>
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
❌ Deploy Preview for keda failed.
|
@@ -1,15 +1,15 @@ | |||
+++ | |||
title = "Redis Lists" | |||
title = "Redis Lists Or Strings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed redis-lists.md to redis.md because there is more than just a list, is this acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this could break the current naming of the urls. @zroubalik @wozniakjan ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that case, we should probably also rename all the references, no?
not sure how many of these are relevant for a rename
$ grep . -nre '/scalers/redis-lists' | wc -l
1448
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If change, then I would probably go with just Redis
Do you mean breaking urls between versions of this scaler, or what? Then we can probably try to find a solution or just keep the original name.
@@ -1,15 +1,15 @@ | |||
+++ | |||
title = "Redis Lists" | |||
title = "Redis Lists Or Strings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this could break the current naming of the urls. @zroubalik @wozniakjan ?
Signed-off-by: wangrushen <[email protected]>
Provide support for scaling based on Redis Key-Values
Checklist
Related kedacore/keda#5003 kedacore/keda#6276