Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for scaling based on Redis Key-Values #1493

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dovics
Copy link
Contributor

@dovics dovics commented Oct 27, 2024

Provide support for scaling based on Redis Key-Values

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related kedacore/keda#5003 kedacore/keda#6276

@dovics dovics requested a review from a team as a code owner October 27, 2024 14:21
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Oct 27, 2024

Deploy Preview for keda failed.

Name Link
🔨 Latest commit 2ba85bb
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6728c463cc5b6a0008884314

@@ -1,15 +1,15 @@
+++
title = "Redis Lists"
title = "Redis Lists Or Strings"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed redis-lists.md to redis.md because there is more than just a list, is this acceptable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this could break the current naming of the urls. @zroubalik @wozniakjan ?

Copy link
Member

@wozniakjan wozniakjan Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case, we should probably also rename all the references, no?

not sure how many of these are relevant for a rename

$ grep . -nre '/scalers/redis-lists' | wc -l
1448

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If change, then I would probably go with just Redis

Do you mean breaking urls between versions of this scaler, or what? Then we can probably try to find a solution or just keep the original name.

content/docs/2.16/scalers/redis.md Outdated Show resolved Hide resolved
content/docs/2.16/scalers/redis.md Outdated Show resolved Hide resolved
content/docs/2.16/scalers/redis-cluster.md Outdated Show resolved Hide resolved
content/docs/2.16/scalers/redis-sentinel.md Outdated Show resolved Hide resolved
content/docs/2.16/scalers/redis-cluster.md Outdated Show resolved Hide resolved
content/docs/2.16/scalers/redis-sentinel.md Outdated Show resolved Hide resolved
@@ -1,15 +1,15 @@
+++
title = "Redis Lists"
title = "Redis Lists Or Strings"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this could break the current naming of the urls. @zroubalik @wozniakjan ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants