Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which (observability) metrics are initialized and which not #5609

Closed
JorTurFer opened this issue Mar 15, 2024 · 8 comments · Fixed by kedacore/keda-docs#1425
Closed
Assignees
Labels
docs good first issue Good for newcomers help wanted Looking for support from community

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Mar 15, 2024

Proposal

We expose multiple metrics but not all of them are initialized. They aren't init because it's impossible, e.g: we can't init a metric about ScaledObject latencies if there isn't any ScaledObject. Other case is when users expect information about CPU/Memory (scalers not managed by KEDA metrics server, so we cannot expose some values)

This is something that we know, but we should explain this in docs to make users aware about these limitations

@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Mar 15, 2024
@JorTurFer JorTurFer added help wanted Looking for support from community good first issue Good for newcomers docs and removed needs-discussion feature-request All issues for new features that have not been committed to labels Mar 15, 2024
@pauldotyu
Copy link
Contributor

Hey @JorTurFer, if you can point me to an area within the code I should be looking at/around, I can help document this.

@JorTurFer
Copy link
Member Author

Sorry for the slow response, we were in KubeCon xD
The metric collectors are here: https://github.com/kedacore/keda/tree/main/pkg/metricscollector
I think that the easiest way is starting a fresh KEDA without any CR and checking the metrics exposed. The problem of the "missing" metrics is that we don't start metrics without info. For example, we cannot init scaler_errors if there isn't any scaler. (and other like that)

IDK if we could check a way to init them, but I have no idea

@pauldotyu
Copy link
Contributor

Thanks @JorTurFer and no worries on the slow response. I saw you and @zroubalik were busy at KubeCon. Great entertaining session BTW!!

If you can assign this one to me, I'll dig in.

Copy link

stale bot commented Jun 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jun 4, 2024
Copy link

stale bot commented Jun 11, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Jun 11, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Jun 11, 2024
@zroubalik zroubalik reopened this Jun 11, 2024
@github-project-automation github-project-automation bot moved this from Ready To Ship to Proposed in Roadmap - KEDA Core Jun 11, 2024
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jun 11, 2024
@pauldotyu
Copy link
Contributor

@JorTurFer Apologies... I sat on this for far too long. I did some quick testing on this and saw that only the keda_build_info metric gets emitted without any scalers deployed. Added a note to the doc on in the keda-docs repo. So, if you think this will be sufficient, then I can go ahead and submit this PR. kedacore/keda-docs#1425

@JorTurFer
Copy link
Member Author

Yeah, if keda_build_info it's the only one, keeping it clearly documented it's nice and enough :)

@pauldotyu
Copy link
Contributor

Sounds good. The PR should be ready for review. kedacore/keda-docs#1425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs good first issue Good for newcomers help wanted Looking for support from community
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants