Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a note about Prometheus metrics exposed on metrics endpoint #1425

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

pauldotyu
Copy link
Contributor

Clarifying that Prometheus metrics emitted depends on scalers are deployed.

Resolves: kedacore/keda#5609

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 673871d
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/669eb64509165f0008929510
😎 Deploy Preview https://deploy-preview-1425--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pauldotyu pauldotyu marked this pull request as ready for review July 22, 2024 19:43
@pauldotyu pauldotyu requested a review from a team as a code owner July 22, 2024 19:43
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @zroubalik

@zroubalik zroubalik merged commit c9b0df7 into kedacore:main Jul 30, 2024
6 of 7 checks passed
shubhusion pushed a commit to shubhusion/keda-docs that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document which (observability) metrics are initialized and which not
3 participants