Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update golang-ci in contribution guide #4904

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Aug 24, 2023

Update golangci-lint version documented in CONTRIBUTING.md since old version doesn't support go 1.20

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #

Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou SpiritZhou requested a review from a team as a code owner August 24, 2023 02:52
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Learn more about:

@tomkerkhove tomkerkhove changed the title Update CONTRIBUTING.md docs: Update golang-ci in contribution guide Aug 24, 2023
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tomkerkhove tomkerkhove enabled auto-merge (squash) August 24, 2023 05:01
@tomkerkhove tomkerkhove merged commit 5a28f35 into kedacore:main Aug 24, 2023
20 checks passed
yoongon pushed a commit to yoongon/keda that referenced this pull request Aug 26, 2023
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: Yoon Park <[email protected]>
novicr pushed a commit to novicr/keda that referenced this pull request Aug 26, 2023
Signed-off-by: SpiritZhou <[email protected]>
Adarsh-verma-14 pushed a commit to Adarsh-verma-14/keda that referenced this pull request Sep 4, 2023
Signed-off-by: SpiritZhou <[email protected]>
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: anton.lysina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants