Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Scaler: Add UnsafeSsl flag #4911

Merged

Conversation

BojanZelic
Copy link
Contributor

@BojanZelic BojanZelic commented Aug 25, 2023

Adds an unsafeSsl flag for kafka autoscaler; When we want to connect to a kafka cluster (w/TLS) but the certificate is self signed or invalid (name mismatch, expired, ect..)

fixes #4977

Checklist

@BojanZelic BojanZelic requested a review from a team as a code owner August 25, 2023 19:12
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Learn more about:

@BojanZelic BojanZelic force-pushed the support-unsafeSSL-for-kafka-autoscaling branch from 565685a to 6dd78cc Compare August 25, 2023 19:14
@BojanZelic BojanZelic force-pushed the support-unsafeSSL-for-kafka-autoscaling branch from 6dd78cc to 53a0f18 Compare August 25, 2023 20:30
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a nit in the Changelog.

@sansmoraxz FYI

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BojanZelic there's still a conflict in changelog :(

@BojanZelic
Copy link
Contributor Author

@zroubalik fixed

@zroubalik
Copy link
Member

zroubalik commented Sep 18, 2023

/run-e2e kafka
Update: You can check the progress here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 10841af into kedacore:main Sep 26, 2023
18 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Signed-off-by: Bojan Zelic <[email protected]>
Signed-off-by: anton.lysina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka Scaler: Add UnsafeSsl flag
5 participants