Update renovate.json to use pinned commits #4958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.renovatebot.com/modules/manager/github-actions/#additional-information Signed-off-by: Jorge Turrado Ferrero <[email protected]>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
tomkerkhove
approved these changes
Sep 11, 2023
|
I'm OK to add it, but do you have any concerns with just version based? In the end, we should assume they don't update a version, no? Or just want to be rather safe than sorry? |
zroubalik
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
LGTM, great change.
@tomkerkhove it is safer no to trust versions :)
GH has marked that approach as risky, and tooling around detect it. e.g: I had to disable the rule from semgrep |
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
https://docs.renovatebot.com/modules/manager/github-actions/#additional-information Signed-off-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: anton.lysina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.renovatebot.com/modules/manager/github-actions/#additional-information