Metric Server - consolidate apiserver to one port #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
Signed-off-by: Bojan Zelic <[email protected]>
BojanZelic
force-pushed
the
keda-metrics-consolidate-to-one-port
branch
from
74261b7
to
2d665ab
Compare
zroubalik
reviewed
Sep 19, 2023
Signed-off-by: Bojan Zelic <[email protected]>
Signed-off-by: Bojan Zelic <[email protected]>
Signed-off-by: Bojan Zelic <[email protected]>
|
This looks amazing! Thanks for the hard research that you have done ❤️ |
zroubalik
reviewed
Sep 20, 2023
Signed-off-by: Bojan Zelic <[email protected]>
|
@JorTurFer added the additional e21e tests to cover both the controller-runtime and apiserver metrics |
1 task
zroubalik
reviewed
Sep 21, 2023
zroubalik
reviewed
Sep 21, 2023
|
/run-e2e prometheus |
Signed-off-by: Bojan Zelic <[email protected]>
…om:BojanZelic/keda into keda-metrics-consolidate-to-one-port
|
/run-e2e |
zroubalik
approved these changes
Sep 25, 2023
1 task
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
Signed-off-by: Bojan Zelic <[email protected]> Signed-off-by: anton.lysina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes #4460
Relates to kedacore/keda-docs#1225