Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve azure podIdentity logs #5007

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

JorTurFer
Copy link
Member

This PR adds some logs to the azure chained provider to help on cases as #5006

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #5006

@JorTurFer JorTurFer requested a review from a team as a code owner September 27, 2023 07:11
@JorTurFer
Copy link
Member Author

JorTurFer commented Sep 27, 2023

/run-e2e azure
Update: You can check the progress here

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer
Copy link
Member Author

/skip-e2e

@JorTurFer
Copy link
Member Author

As my last commit was for adding a whitespace (to split import groups) and the other commit passed the e2e tests, I have skipped e2e test

@JorTurFer JorTurFer enabled auto-merge (squash) September 27, 2023 08:01
@JorTurFer JorTurFer merged commit 089f22f into kedacore:main Sep 27, 2023
19 checks passed
@JorTurFer JorTurFer deleted the improve-azure-chained-token branch September 27, 2023 08:20
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants