feat: add TLS support for IBM MQ scaler #5976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickbrouwer
force-pushed
the
main
branch
7 times, most recently
from
b1c30ae
to
200ee44
Compare
Signed-off-by: rickbrouwer <[email protected]>
JorTurFer
reviewed
Jul 24, 2024
|
/run-e2e ibmmq |
|
There is an issue with the unit test.
|
Signed-off-by: Rick Brouwer <[email protected]>
|
@JorTurFer fixed the issue in the unit test 🙏 |
|
/run-e2e ibmmq |
|
e2e test is failing and I can see this message: 2024-07-24T15:09:30Z ERROR scale_handler error getting scale decision {"scaledObject.Namespace": "ibmmq-test-ns", "scaledObject.Name": "ibmmq-test-so", "scaler": "IBMMQScaler", "error": "error inspecting IBM MQ queue depth: failed to contact MQ via REST: Post \"https://ibm-mq-dev-ibm-mq.ibmmq-test-ns.svc:9443/ibmmq/rest/v2/admin/action/qmgr/testqmgr/mqsc\": tls: failed to verify certificate: x509: certificate is valid for localhost, not ibm-mq-dev-ibm-mq.ibmmq-test-ns.svc"}
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScalerState
/workspace/pkg/scaling/scale_handler.go:780
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScaledObjectState.func1
/workspace/pkg/scaling/scale_handler.go:633 |
JorTurFer
reviewed
Jul 24, 2024
Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: rickbrouwer <[email protected]>
|
/run-e2e ibmmq |
JorTurFer
approved these changes
Jul 25, 2024
|
Thanks a lot for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IBM MQ scaler does not support authentication with TLS certs. This contributing adds support to enable authentication with TLS certs within the existing IBM MQ scaler by extending it, possibly with additional optional parameters.
Currently, MQ appliance is expecting the Basic Auth credentials as well along with certificates. The change is therefore made in such a way that Basic Auth remains necessary if you also provide a TLS certificate.
The change has been tested against our own IBM MQ appliances.
Checklist
When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)
Fixes #5974
Docs: 1433