-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple queues at the IBMMQ scaler #6182
Conversation
5a9617c
to
8651e67
Compare
593c9db
to
afd816d
Compare
Signed-off-by: rickbrouwer <[email protected]>
afd816d
to
9d2717a
Compare
a31b5ed
to
dc66dcc
Compare
Signed-off-by: Rick Brouwer <[email protected]>
dc66dcc
to
d9795c1
Compare
I see the use case of this feature, but IMHO we should expose the aggregation algorithm if we allow multiple queries in the same trigger. If you check the RabbitMQ trigger, it exposes the aggregation as parameter (min, max, sum). |
I totally agree with you. That is a nicer setup. I will make this adjustment and add it. |
e4e6830
to
3098cf2
Compare
Signed-off-by: Rick Brouwer <[email protected]>
3098cf2
to
272e04f
Compare
Signed-off-by: Rick Brouwer <[email protected]>
Signed-off-by: rickbrouwer <[email protected]>
22d4b75
to
77c8ac7
Compare
d97486c
to
28b5841
Compare
Signed-off-by: rickbrouwer <[email protected]>
28b5841
to
ba9d2f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! PTAL @zbynek @wozniakjan
/run-e2e ibm |
I guess you meant @zroubalik |
lol, sorry :( yes... I meant @zroubalik |
I wish I had that GH handle :)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
/run-e2e ibm |
Changed the
queueName
parameter so that it accepts multiple queues (comma (,
) separated). The code is is changed so it's request the current depth per queue and only use the current depth from the queue with the most messages. Because it's accepts multiple queues,queueNames
will be also supported.Also added extra check for authentication error. When an incorrect password is given the error message is
error inspecting IBM MQ queue depth: failed to parse response from REST call
. The reason is a bit unclear. That's why I added a better error messageerror inspecting IBM MQ queue depth: authentication failed: incorrect username or password
.Checklist
Fixes #6181
Docs: kedacore/keda-docs#1473