Deprecate type setting CPU/MEM and tls setting IBMMQ #6698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: Rick Brouwer <[email protected]>
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
changed the title
1 task
JorTurFer
reviewed
Apr 21, 2025
rickbrouwer
force-pushed
the
deprecations
branch
from
56d69e0 to
70d10a1
Compare
JorTurFer
reviewed
Apr 21, 2025
rickbrouwer
force-pushed
the
deprecations
branch
2 times, most recently
from
f650e50 to
8ea97cd
Compare
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
force-pushed
the
deprecations
branch
from
8ea97cd to
1be0751
Compare
|
/run-e2e sequential|cpu|memory|ibm |
rickbrouwer
force-pushed
the
deprecations
branch
from
ae12a0c to
d995208
Compare
|
/run-e2e sequential|cpu|memory|ibm |
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
force-pushed
the
deprecations
branch
from
9fa2688 to
39510f0
Compare
|
/run-e2e internal|sequential|cpu|memory|ibm |
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy type and tls settings in favor of metricType and unsafeSsl, cleans up deprecated Prometheus webhook metrics, and updates the typed‐config handling for deprecation notices.
- Switch CPU/Memory scaler tests from
typetometricType - Update
typed_configto emit errors or events on deprecated parameters and adjust corresponding tests - Remove deprecated Prometheus webhook counters and deprecate
tlsin the IBM MQ scaler
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/scalers/memory/memory_test.go | Replace type metadata with metricType in memory scaler tests |
| tests/scalers/cpu/cpu_test.go | Replace type metadata with metricType in CPU scaler tests |
| tests/internals/scaled_object_validation/scaled_object_validation_test.go | Update validation tests to use metricType instead of type |
| pkg/scalers/scalersconfig/typed_config_test.go | Refactor deprecation tests for deprecated and deprecatedAnnounce |
| pkg/scalers/scalersconfig/typed_config.go | Change deprecation logic to return errors/events with new formatting |
| pkg/scalers/ibmmq_scaler.go | Deprecate tls field and remove its backward‐compatibility mapping |
| pkg/scalers/cpu_memory_scaler.go | Deprecate type field in metadata and remove legacy parsing |
| pkg/metricscollector/webhook/webhook_prommetrics.go | Remove old Prometheus webhook deprecation counters |
| CHANGELOG.md | Add entries for removed deprecations and breaking changes |
Comments suppressed due to low confidence (2)
pkg/scalers/scalersconfig/typed_config.go:201
- Add a newline when printing the deprecation message (e.g., use fmt.Println or append "\n") so each log entry appears on its own line.
fmt.Print(message)
CHANGELOG.md:93
- [nitpick] Consider rephrasing this entry for clarity and consistency with other items, for example: 'Remove deprecations for Prometheus webhook "prommetrics" metrics'.
- **General**: Remove Prometheus webhook prommetrics deprecations ([#6698](https://github.com/kedacore/keda/pull/6698))
wozniakjan
approved these changes
Jun 15, 2025
wozniakjan
reviewed
Jun 15, 2025
| } | ||
| if exists && params.DeprecatedAnnounce != "" { | ||
| if sc.Recorder != nil { | ||
| message := fmt.Sprintf("Scaler %s info: %s", sc.TriggerType, params.DeprecatedAnnounce) | ||
| message := fmt.Sprintf("scaler %s info: %s", sc.TriggerType, params.DeprecatedAnnounce) | ||
| fmt.Print(message) |
There was a problem hiding this comment.
Note for myself, I must have forgotten this in an earlier commit, I should check it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Prometheus webhook prommetrics deprecations
Remove the
typesetting in CPU Memory scalerRemove
tlssetting in the IBM MQ scalerUpdate
typed_configconform governance deprecationsChecklist
Fixes #6348 #6095
Docs: kedacore/keda-docs#1564
Relates to #2844