Add error and event for mismatching input property #6763
Conversation
Signed-off-by: zhenghanzhou <[email protected]>
Signed-off-by: zhenghanzhou <[email protected]>
Signed-off-by: zhenghanzhou <[email protected]>
| message := fmt.Sprintf("Unmatched input property %s in scaler %s", key+suffix, sc.ScalableObjectType) | ||
| // Just logging as it's optional property checking and should not block the scaling | ||
| logger.Error(nil, message) | ||
| sc.Recorder.Event(sc.ScaledObject, corev1.EventTypeNormal, eventreason.KEDAScalersInfo, message) |
There was a problem hiding this comment.
Should we use corev1.EventTypeWarning instead of corev1.EventTypeNormal here?
There was a problem hiding this comment.
I could see a good rationale for either type. My usual rule of thumb is
- use
Normalwhen something successfully happened and a user should know about it - e.g. volume is mounted, some connection was established... - use
Warningwhen something unexpected happened and it has negative impact for the user - e.g. volume didn't get mounted, some connection got broken...
This case "an extra parameter user provided is ignored". KEDA is successful at ignoring it but it might have unexpected result for the user, so a bit of both. I'd probably also pick Warning event but I can be easily convinced for Normal.
|
/run-e2e |
There was a problem hiding this comment.
lgtm, thank you!
Maybe the event type deserves a little bit of discussion as mentioned here by @dttung2905 but I'm happy with either result of the discussion.
Signed-off-by: Zhenghan Zhou <[email protected]>
|
/run-e2e |
Provide a description of what has been changed
Checklist
Fixes #
Relates to # #6721