-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Option to use message count as metric in kafka scaler on invalid offset #6775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Option to use message count as metric in kafka scaler on invalid offset #6775
Conversation
3791ea8
to
d303e54
Compare
Hi, I did my best to prepare the PR in the appropriate way (signed commits, added tests, added docs PR) Also I didn't touch experimental kafka-go scaler, to minimize back-n-force (assumed it would be better to polish one first, than copy to the second one if required) P.S.: For what it's worth, I did build this version locally and deployed to the cluster, and it seems to work as expected so far |
Based on other PRs, I'll tag @JorTurFer , @zroubalik and @dttung2905 |
Signed-off-by: DaniilAnichin <[email protected]>
d303e54
to
e879450
Compare
The code looks correct, but I don't know anything about kafka, @dttung2905 or @zroubalik PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So sorry for the late reply. I have put a 👀 icon on it and was actually reviewing the PR. But for some reason I left half way and totally forget about it 😞
LGTM too !
/run-e2e kafka |
/run-e2e kafka |
Provide a description of what has been changed
Checklist
Fixes #
Relates to keda-docs PR