Skip to content

refactor external scaler #6829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor external scaler #6829

wants to merge 3 commits into from

Conversation

dttung2905
Copy link
Contributor

@dttung2905 dttung2905 commented Jun 9, 2025 •
edited
Loading

Checklist

Relates to #5797

@dttung2905
refactor external scaler
ca4435f 
Signed-off-by: dttung2905 <[email protected]>
@dttung2905 dttung2905 requested a review from a team as a code owner June 9, 2025 20:13
@dttung2905
Fix ci lint error
b6c7b8d 
Signed-off-by: dttung2905 <[email protected]>
@dttung2905
Copy link
Contributor Author

dttung2905 commented Jun 10, 2025 •
edited by github-actions bot
Loading

/run-e2e external

Update: You can check the progress here

@wozniakjan wozniakjan requested a review from Copilot June 11, 2025 10:47
Copilot
Copilot AI reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@dttung2905
Fix CI Failure
8a4594b 
Signed-off-by: dttung2905 <[email protected]>
@dttung2905
Copy link
Contributor Author

@wozniakjan not sure why the e2e command failed with

Run MESSAGE="$COMMENT_BODY"
bash: line 1: /go/bin/golangci-lint: No such file or directory
go run -tags e2e ./tests/run-all.go regex-check
No test has been executed, please review your regex: 'external
'
exit status 1
make: *** [Makefile:107: e2e-regex-check] Error 1

where previous PR that runs this command passes 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dttung2905