fix: support nested structures in New Relic scaler #6831
+116
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2025
|
/run-e2e newrelic |
wozniakjan
reviewed
Jun 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the New Relic scaler to correctly parse responses that contain nested JSON structures, addressing issues where percentile query responses were not handled correctly.
- Enhanced response parsing logic to support nested structures.
- Added comprehensive test cases to cover various response scenarios including nested percentile values and error conditions.
- Updated the changelog to document the feature.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/scalers/newrelic_scaler_test.go | Added new test cases to verify nested JSON response parsing behavior. |
| pkg/scalers/newrelic_scaler.go | Updated the parsing logic to handle nested maps in the query results. |
| CHANGELOG.md | Updated changelog with an entry for the new nested structures support. |
|
/run-e2e newrelic |
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
changed the title
|
/run-e2e newrelic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced response parser to handle nested map structures. The New Relic scaler fails to parse percentile query responses due to nested JSON structure.
Checklist
Fixes #6825