Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add nightly build #283

Merged
merged 1 commit into from
Jul 27, 2023
Merged

chore: Add nightly build #283

merged 1 commit into from
Jul 27, 2023

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Jul 27, 2023

Description

related to: kedro-org/kedro#2335

The CI on kedro-plugins is not run regularly - for the core Kedro repo we have frequent changes so any dependency changes will be found out pretty quickly. For plugins, there could be a dependency change but we only have new commits after a few months. In this case, it is unclear whether the new changes break the CI or something in between happened, often it takes a long time to isolate the error.

Development notes

Added cron jobs to CI.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@SajidAlamQB SajidAlamQB self-assigned this Jul 27, 2023
@SajidAlamQB SajidAlamQB changed the title Add nightly build chore: Add nightly build Jul 27, 2023
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://crontab.guru this is correct cron syntax

image

so I'm +1, thanks @SajidAlamQB!

Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, thanks @SajidAlamQB!

@SajidAlamQB SajidAlamQB merged commit 1f3b3b9 into main Jul 27, 2023
53 of 54 checks passed
@SajidAlamQB SajidAlamQB deleted the feat/Add-nightly-build branch July 27, 2023 09:04
PtrBld pushed a commit to PtrBld/kedro-plugins that referenced this pull request Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants