Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix paths filter for triggering TSC vote check #902

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Oct 22, 2024

Description

I noticed the TSC vote check wasn't triggered on PRs with changes in the core datasets (e.g. #881). This doesn't need a vote, but the check should run.

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@merelcht merelcht marked this pull request as ready for review October 22, 2024 10:25
@merelcht merelcht changed the title build: GH triggered? build: fix paths filter for triggering TSC vote check Oct 22, 2024
@merelcht merelcht self-assigned this Oct 22, 2024
@merelcht merelcht enabled auto-merge (squash) October 22, 2024 10:27
@merelcht merelcht merged commit 92952cf into main Oct 22, 2024
45 checks passed
@merelcht merelcht deleted the test-review-trigger branch October 22, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants