-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasets): Created table_args to pass to create_table
, create_view
, and table
methods
#909
Open
mark-druffel
wants to merge
10
commits into
kedro-org:main
Choose a base branch
from
mark-druffel:fix/datasets/ibis-TableDataset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
add5a38
Added table_args, combined save_args and table_args for save method t…
mark-druffel ef3712e
Added docstring and release note
mark-druffel 0a40d23
Updated release notes as feature, not bug
mark-druffel d6ea74e
Merge branch 'main' into fix/datasets/ibis-TableDataset
deepyaman 8897a01
Changes to fix bug with table_args & save_args
mark-druffel e0e2df9
Merge branch 'main' into fix/datasets/ibis-TableDataset
mark-druffel 6b86358
Linting on table_dataset.py
mark-druffel b738a92
Merge branch 'fix/datasets/ibis-TableDataset' of https://github.com/m…
mark-druffel 4a47336
Ran table_dataset through black
mark-druffel dd0459d
Merge branch 'main' into fix/datasets/ibis-TableDataset
mark-druffel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a bit magical to me. It's not really consistent with the docstring, either, which says that arguments will be passed to
create_{materialized}
; in reality, the user needs to know that justdatabase
will be passed.I personally would recommend one of two approaches. One is to not do anything special here; the user can pass
database
insave_args
anddatabase
intable_args
, and, while it may feel duplicative, at least it's explicit. The other approach to make an explicitdatabase
keyword for the dataset, and likely raise an error ifdatabase
is specified insave_args
and/ortable_args
if also passed explicitly.@mark-druffel does this make sense, and do you have a preference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepyaman As discussed yesterday, I've moved database to the top-level as discussed. I'm trying to push the changes, but I'm getting blocked by pre-commit now that I have it setup properly.
When it ran, it changed a bunch of files I never touched. I staged those as well (not sure if I should've), but my commit still failed because of Black. I've run black manually on the file I changed too to try to lint the file. Any suggestions how I can get this working properly? 😬